Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace weight int with string in mods #36333

Merged
merged 1 commit into from
Dec 22, 2019
Merged

Replace weight int with string in mods #36333

merged 1 commit into from
Dec 22, 2019

Conversation

anothersimulacrum
Copy link
Member

Summary

SUMMARY: None

Purpose of change

Weight strings provide units and are more readable.

Describe the solution

Replace weight int with string in mods.

Testing

Data from non-blacklisted mods loaded in tests without error.

Additional context

May need some manual review.

@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON Items / Item Actions / Item Qualities Items and how they work and interact Mods Issues related to mods or modding labels Dec 22, 2019
@weekly-digest weekly-digest bot mentioned this pull request Dec 22, 2019
Closed
@ZhilkinSerg ZhilkinSerg merged commit 869f9b4 into CleverRaven:master Dec 22, 2019
@molkero molkero mentioned this pull request Dec 22, 2019
Merged
@anothersimulacrum anothersimulacrum deleted the mod-wstr branch December 22, 2019 17:49
@weekly-digest weekly-digest bot mentioned this pull request Dec 29, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anothersimulacrum @ZhilkinSerg